Open
Conversation
Nikita5390
added
the
ready for review
Chudopal
requested changes
Jun 14, 2022
Owner
Chudopal
left a comment
Chudopal
left a comment
There was a problem hiding this comment.
Прислушайся к рекомендациям и вниматльно смотри, что добавляешь в коммит
Comment on lines
+23
to
+26
|
|
||
|
|
||
|
|
||
|
|
Owner
There was a problem hiding this comment.
чето много очень строчек в конце файла, уменьши до 1 пустой
Comment on lines
+46
to
+62
| #extra In progress | ||
| # @app.route("/cars/<option>", methods=["GET"]) | ||
| # def get_options(option): | ||
| # response = get_cars().get('cars') | ||
| # | ||
| # id = request.args.get("id") | ||
| # price_usd = request.args.get("price_usd") | ||
| # brand = request.args.get("brand") | ||
| # model = request.args.get("model") | ||
| # generation = request.args.get("generation") | ||
| # year = request.args.get("year") | ||
| # rain_detector = request.args.get("rain_detector") | ||
| # interior_material = request.args.get("interior_material") | ||
| # created_advert = request.args.get("created_advert") | ||
| # ....... | ||
| # response = UserStorage('1.json').find_users(name=name, job=job) | ||
| # return jsonify(list(response)) |
Comment on lines
+1
to
+17
| { | ||
| "cars_number": 25, | ||
| "cars": [ | ||
| { | ||
| "id": 101068323, | ||
| "price_usd": 22300, | ||
| "brand": "Nissan", | ||
| "model": "Leaf", | ||
| "generation": "II", | ||
| "year": "2017", | ||
| "rain_detector": true, | ||
| "interior_material": "ткань", | ||
| "created_advert": "2022-05-01T18:59:04+0000" | ||
| } | ||
|
|
||
| ] | ||
| } No newline at end of file |
Owner
There was a problem hiding this comment.
если этот файл твоего хранилища и он не нужен для задачи - то не добавляй такое в коммит
| @app.route("/schedule/<string:week_day>/<string:date>") | ||
| def get_schedule(week_day, date): | ||
| date = f"{week_day}, {date}" | ||
| data = schedule_storage.get_data().get('monday')[0].items() |
Owner
There was a problem hiding this comment.
Да, по дню недели верно, но фильтрация по дате отсуствует, надо добавить
Chudopal
added
in progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.